StrategyManagerLib

All logic lives here; the StrategyManager facet is a pure delegator.

Must be called inside a pre/postInitializer block. AccessControl must already be initialized.

Trust assumption: each registered strategy must accurately report totalAssetsManaged(). A malicious strategy could inflate this value, causing the vault to miscalculate share prices. Only add audited strategies. Reverts if any strategy's read reverts (or the sum overflows); the vault then fails closed until the admin force-removes a reverting strategy through removeStrategy (which latches deposits closed until clearDepositLatch), or, as a last resort, the vault admin points VaultCore.setStrategyManager at a fresh manager (which latches the vault's deposits, #305).

Inner logic for setVault (no auth check).

Reverts with IStrategyManager.StrategyManagerStrategyNotEmpty if the strategy already reports a balance, and bubbles the revert if its totalAssetsManaged() read fails.

Inner logic for addStrategy.

A strategy whose totalAssetsManaged() read fails is force-removed and latches deposits closed (see _removeStrategy).

Inner logic for removeStrategy. Force removal: a failing balance read makes totalAllocated revert, which makes the vault's totalAssets() revert and freezes the vault (fail closed). To recover, a strategy whose read reverts or returns malformed data is removed without the balance check and emits IStrategyManager.StrategyForceRemoved. Any funds it still holds leave the vault's NAV, and funds it later returns to the vault, by any path, accrue to whoever holds shares at that moment. So that a depositor entering at the lower NAV cannot capture them (#270), the removal also latches deposits closed and emits IStrategyManagerRecovery.DepositLatchSet: exits reopen (capped at idle), entries stay closed until the admin calls clearDepositLatch. Funds returned after the latch is cleared accrue to whoever holds shares then. _addStrategy rejects re-adding the strategy while it still reports a balance. A strategy that reports a well-formed but overflowing balance also freezes the vault, yet is not a failed read here and cannot be force-removed; the last resort is VaultCore.setStrategyManager with a fresh manager, which drops all of this manager's strategies from the NAV and, since this manager still reports allocations (or cannot answer, when its own sum overflows), latches the vault's deposits until the vault admin clears them (IVaultCoreRecovery, #305).

Inner logic for clearDepositLatch (no auth check).

Inner logic for updateStrategyTarget.

Anyone can call; no funds move. Useful for off-chain indexers tracking yield accrual.

Uses a two-pass approach to avoid order-dependent atomicity failures (M-1): Pass 1 — process all over-allocated strategies (withdrawals back to vault) first. Pass 2 — process all under-allocated strategies (allocations from vault) second. This guarantees the vault holds maximum idle balance before any allocation is attempted, regardless of strategy registration order. A final pass then deploys each protocol adapter's idle (#221).

Inner rebalance logic (called after reentrancy lock is acquired).

Recalls requested from strategy (which reported current) and checks it by value, not by the amount asked (H-3, #221). received is the vault's actual idle delta and released the drop in the strategy's reported balance. Reverts with IStrategyManager.StrategyManagerWithdrawShortfall when released exceeds received by more than REBALANCE_SHORTFALL_TOLERANCE: the recall lost value (slippage, an exit fee, or a strategy writing off more than it paid), which a permissionless caller must not be able to realize. A recall that delivers less than asked while the strategy still reports the remainder (the Lido buffer, Aave/Compound short of cash, a UniswapV3 position) is an honest partial recall: it completes, emits IStrategyManager.StrategyPartiallyRecalled, and the strategy stays over target until a later rebalance.

Calls deploy() on strategy when it holds idle asset_ and advertises IProtocolAdapter through ERC-165, so allocations do not sit idle in the adapter (#221; the adapters only accept deploy from their operator, this manager). Plain IStrategys are skipped. A reverting deploy (paused adapter or protocol, a supply cap, an operator not yet wired) is caught and reported with IStrategyManager.StrategyDeployFailed: the idle stays in the adapter, counted in its NAV, and never blocks the rebalance.